[igt-dev] [PATCH i-g-t 3/4] tests/xe/xe_guc_pc: Remove rc6 tests

[Gupta, Anshuman]

> -----Original Message-----
> From: Tauro, Riana <riana.tauro at intel.com>
> Sent: Wednesday, June 28, 2023 3:05 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Tauro, Riana <riana.tauro at intel.com>; Gupta, Anshuman
> <anshuman.gupta at intel.com>; Dixit, Ashutosh <ashutosh.dixit at intel.com>;
> Belgaumkar, Vinay <vinay.belgaumkar at intel.com>; Nilawar, Badal
> <badal.nilawar at intel.com>; kamil.konieczny at linux.intel.com; Sundaresan,
> Sujaritha <sujaritha.sundaresan at intel.com>
> Subject: [PATCH i-g-t 3/4] tests/xe/xe_guc_pc: Remove rc6 tests
> 
> Remove these tests as sysfs paths have been changed and a generic naming
> used.
> 
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/441
> Signed-off-by: Riana Tauro <riana.tauro at intel.com>
LGTM.
Reviewed-by: Anshuman Gupta <anshuman.gupta at intel.com>
> ---
>  tests/xe/xe_guc_pc.c | 44 --------------------------------------------
>  1 file changed, 44 deletions(-)
> 
> diff --git a/tests/xe/xe_guc_pc.c b/tests/xe/xe_guc_pc.c index
> 89d5ae9e..79359942 100644
> --- a/tests/xe/xe_guc_pc.c
> +++ b/tests/xe/xe_guc_pc.c
> @@ -348,27 +348,6 @@ static void test_reset(int fd, int sysfs, int gt_id, int
> cycles)
>  	}
>  }
> 
> -
> -/**
> - * SUBTEST: rc6_on_idle
> - * Description: check if GPU is in RC6 on idle
> - * Run type: BAT
> - *
> - * SUBTEST: rc0_on_exec
> - * Description: check if GPU is in RC0 on when doing some work
> - * Run type: BAT
> - */
> -
> -static bool in_rc6(int sysfs, int gt_id) -{
> -	char path[32];
> -	char rc[8];
> -	sprintf(path, "device/gt%d/rc_status", gt_id);
> -	if (igt_sysfs_scanf(sysfs, path, "%s", rc) < 0)
> -		return false;
> -	return strcmp(rc, "rc6") == 0;
> -}
> -
>  igt_main
>  {
>  	struct drm_xe_engine_class_instance *hwe; @@ -460,29 +439,6 @@
> igt_main
>  		}
>  	}
> 
> -	igt_subtest("rc6_on_idle") {
> -		igt_require(!IS_PONTEVECCHIO(xe_dev_id(fd)));
> -		xe_for_each_gt(fd, gt) {
> -			assert(igt_wait(in_rc6(sysfs, gt), 1000, 1));
> -		}
> -	}
> -
> -	igt_subtest("rc0_on_exec") {
> -		igt_require(!IS_PONTEVECCHIO(xe_dev_id(fd)));
> -		xe_for_each_gt(fd, gt) {
> -			assert(igt_wait(in_rc6(sysfs, gt), 1000, 1));
> -			xe_for_each_hw_engine(fd, hwe)
> -				igt_fork(child, ncpus) {
> -					igt_debug("Execution Started\n");
> -					exec_basic(fd, hwe,
> MAX_N_ENGINES, 16);
> -					igt_debug("Execution Finished\n");
> -				}
> -			/* While exec in threads above, let's check rc_status
> */
> -			assert(igt_wait(!in_rc6(sysfs, gt), 1000, 1));
> -			igt_waitchildren();
> -		}
> -	}
> -
>  	igt_fixture {
>  		xe_for_each_gt(fd, gt) {
>  			set_freq(sysfs, gt, "min", stash_min);
> --
> 2.40.0