[igt-dev] [PATCH i-g-t] tests/i915/gem_userptr_blits: skip set-cache-level subtest on MTL platform

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Mar 2 11:02:39 UTC 2023


Hi Vikas,

On 2023-03-02 at 12:03:34 +0530, Vikas Srivastava wrote:
> SET_CACHE ioctl is not supported on latest platform like MTL
> so instead of failing in set-cache-level subtest just skip it.

You already have patchset: tests/i915: skip gem_set_caching call for mtl
Why not place it there ?

> 
> Signed-off-by: Vikas Srivastava <vikas.srivastava at intel.com>
> ---
>  tests/i915/gem_userptr_blits.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
> index 483570d0a..402d8810b 100644
> --- a/tests/i915/gem_userptr_blits.c
> +++ b/tests/i915/gem_userptr_blits.c
> @@ -2417,8 +2417,11 @@ igt_main_args("c:", NULL, help_str, opt_handler, NULL)
>  			test_sd_probe(fd);
>  		}
>  
> -		igt_subtest("set-cache-level")
> +		igt_subtest("set-cache-level") {
> +			igt_require_f(__gem_set_caching(fd, 0, 0) != -EOPNOTSUPP,

Maybe better to check for MTL here and skip with message ?

Regards,
Kamil

> +				      "set_caching not supported on this platform");
>  			test_set_caching(fd);
> +		}
>  
>  		igt_subtest("userfault")
>  			test_userfault(fd);
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list