[igt-dev] [PATCH i-g-t v2] tests/gem_ccs: Remove block-copy-inplace subtest

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Mar 6 05:46:04 UTC 2023


On Fri, Mar 03, 2023 at 10:24:28AM +0100, Karolina Stolarek wrote:
> In full resolve mode of operation, source and destination have
> to use the same tiling format. block-copy-inplace attempts to
> decompress and detile in the same step, which is not possible.
> Remove the subtest that tries to change the tiling format in-flight.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek at intel.com>

LGTM:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew

> ---
> v2:
>   - Leave the multicopy subtest in, mid and dst surfaces use the same
>     tiling format after all
> 
>  tests/i915/gem_ccs.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/i915/gem_ccs.c b/tests/i915/gem_ccs.c
> index b7e8bda7..fcac1912 100644
> --- a/tests/i915/gem_ccs.c
> +++ b/tests/i915/gem_ccs.c
> @@ -694,14 +694,6 @@ igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL)
>  		block_copy_test(i915, &config, ctx, set, BLOCK_MULTICOPY);
>  	}
>  
> -	igt_describe("Check block-copy flatccs inplace decompression blit");
> -	igt_subtest_with_dynamic("block-copy-inplace") {
> -		struct test_config config = { .compression = true,
> -					      .inplace = true };
> -
> -		block_copy_test(i915, &config, ctx, set, BLOCK_COPY);
> -	}
> -
>  	igt_describe("Check block-multicopy flatccs inplace decompression blit");
>  	igt_subtest_with_dynamic("block-multicopy-inplace") {
>  		struct test_config config = { .compression = true,
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list