[igt-dev] [PATCH i-g-t v4 6/9] lib/intel_batchbuffer: Remove unused includes

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Mar 20 06:38:32 UTC 2023


On Fri, Mar 17, 2023 at 01:37:08PM +0100, Karolina Stolarek wrote:
> The library includes a lot of headers and most of them are
> not needed.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek at intel.com>
> ---
>  lib/intel_batchbuffer.c | 22 ++++------------------
>  1 file changed, 4 insertions(+), 18 deletions(-)
> 
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index a5157194..1b999ca5 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -25,35 +25,21 @@
>   *
>   **************************************************************************/
>  
> -#include <inttypes.h>
> -#include <poll.h>
> -#include <stdlib.h>
> -#include <stdio.h>
> -#include <string.h>
> -#include <assert.h>
>  #include <search.h>
> +#include <glib.h>
>  
> -#include "drm.h"
> -#include "drmtest.h"
>  #include "i915/gem_create.h"
>  #include "intel_batchbuffer.h"
>  #include "intel_bufops.h"
>  #include "intel_chipset.h"
> -#include "intel_reg.h"
> -#include "veboxcopy.h"
>  #include "rendercopy.h"
>  #include "media_fill.h"
> -#include "ioctl_wrappers.h"
> -#include "sw_sync.h"
> -#include "i915/gem_mman.h"
>  #include "media_spin.h"
> +#include "i915/gem_mman.h"
> +#include "veboxcopy.h"

Those two changed place, not a blocker at all:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


> +#include "sw_sync.h"
>  #include "gpgpu_fill.h"
> -#include "igt_aux.h"
> -#include "i830_reg.h"
>  #include "huc_copy.h"
> -#include <glib.h>
> -
> -#include <i915_drm.h>
>  
>  #define BCS_SWCTRL 0x22200
>  #define BCS_SRC_Y (1 << 0)
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list