[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Fix out-of-bound array access

Coelho, Luciano luciano.coelho at intel.com
Fri Mar 17 07:35:45 UTC 2023


On Thu, 2023-03-16 at 21:43 +0530, Swati Sharma wrote:
> With this fix we are solving 2 issues. Firstly, the
> planes_scaling_combo() tests were leaving one scaler assigned
> after running sub-test with two consecutive planes because
> one scaler was getting reused in the next run.
> 
> Secondly, when k == n_planes - 1, we were trying to access
> planes[n_planes], which led to array out of bounds error.
> 
> Suggested-by: Luca Coelho <luciano.coelho at intel.com>
> Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> Reported-by: Luca Coelho <luciano.coelho at intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---

Looks goods.  Thanks for fixing it.

Reviewed-by: Luca Coelho <luciano.coelho at intel.com>

--
Cheers,
Luca.


More information about the igt-dev mailing list