[igt-dev] [PATCH i-g-t v4 23/31] i915/perf: Add support for engine specific metrics

[Dixit, Ashutosh]

On Tue, 21 Mar 2023 17:05:15 -0700, Umesh Nerlige Ramappa wrote:
>

Moving comment and R-b from v3 to v4.

> @@ -276,6 +275,10 @@ static void (*sanity_check_reports)(const uint32_t *oa_report0,
>				    const uint32_t *oa_report1,
>				    enum drm_i915_oa_format format);
>
> +
> +static struct intel_perf_metric_set *metric_set(const struct intel_execution_engine2 *e2);
> +#define default_test_set metric_set(&default_e2)

Can optionally move the function definition here to avoid this
declaration. Otherwise lgtm:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>