[igt-dev] [PATCH i-g-t v4 1/4] intel-ci: update blacklists to work with the Xe driver

[Kamil Konieczny]

Hi Mauro,

On 2023-03-23 at 10:02:18 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> It doesn't make sense to run i915 tests with Xe driver and
> vice-versa. Update testlists to make it clear.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> ---
>  .../{blacklist.txt => i915-blacklist.txt}     |  4 ++++
>  tests/intel-ci/xe-blacklist.txt               | 21 +++++++++++++++++++
>  2 files changed, 25 insertions(+)
>  rename tests/intel-ci/{blacklist.txt => i915-blacklist.txt} (97%)
>  create mode 100644 tests/intel-ci/xe-blacklist.txt

imho we do not need symlink here but if you want to discuss it
please split this move to i915-blacklist.txt and 2/4 into
separate patchseries, so we will not block merging changes to
xe-blacklist.txt and adding igt at xe_.* to blacklist.txt

> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/i915-blacklist.txt
> similarity index 97%
> rename from tests/intel-ci/blacklist.txt
> rename to tests/intel-ci/i915-blacklist.txt
> index 6e5cc43667cf..389a2acb7f44 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/i915-blacklist.txt
> @@ -84,6 +84,10 @@ igt at kms_chamelium_frames@hdmi-.*-planes-random
>  igt at vc4_.*
>  igt at v3d_.*
>  ###############################################
> +# Intel Xe
> +###############################################
> +igt at xe/.*
-------- ^
There is no xe subdirectory with xe tests, all binaries are
named xe_* and are placed in build/tests/

This should be:

igt at xe_.*

> +###############################################
>  # AMD
>  ###############################################
>  igt at amdgpu/.*

See here, all amdgpu binaries are in this subfolder, so '/'
is used.

> diff --git a/tests/intel-ci/xe-blacklist.txt b/tests/intel-ci/xe-blacklist.txt
> new file mode 100644
> index 000000000000..986e91a67069
> --- /dev/null
> +++ b/tests/intel-ci/xe-blacklist.txt
> @@ -0,0 +1,21 @@
> +###############################################
> +# Broadcom
> +###############################################
> +igt at vc4_.*
> +igt at v3d_.*
> +###############################################
> +# Intel i915
> +###############################################
> +igt at i915/.*
---------- ^
Same here,

igt at i915_.*

Add also:

igt at gem.*
igt at gen.*

imho look at tests/i915, we should really put all that here
in alphabetical order and with regexp where possible to make
it as short as possible.

Regards,
Kamil

> +###############################################
> +# AMD
> +###############################################
> +igt at amdgpu/.*
> +###############################################
> +# Panfrost
> +###############################################
> +igt at panfrost_.*
> +###############################################
> +# Qualcomm
> +###############################################
> +igt at msm_.*
> -- 
> 2.39.2
>