[igt-dev] [PATCH i-g-t 1/2] tests/kms_dp_aux_dev: Factor out helper checking for sink detect errors
Imre Deak
imre.deak at intel.com
Thu Mar 23 16:18:07 UTC 2023
For clarity, factor out a helper to check if the AUX transfer failed
due to not detecting the sink being connected.
Signed-off-by: Imre Deak <imre.deak at intel.com>
---
tests/kms_dp_aux_dev.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
index 850ec8e26..86e111bf2 100644
--- a/tests/kms_dp_aux_dev.c
+++ b/tests/kms_dp_aux_dev.c
@@ -42,6 +42,19 @@ static bool is_mst_connector(int drm_fd, uint32_t connector_id)
NULL, NULL);
}
+static bool sink_detect_error(int drm_fd, uint32_t connector_id, int error_code)
+{
+ switch (error_code) {
+ case ETIMEDOUT:
+ return true;
+ case EIO:
+ return is_mst_connector(drm_fd, connector_id) ||
+ is_amdgpu_device(drm_fd);
+ default:
+ return false;
+ };
+}
+
static bool test(int drm_fd, uint32_t connector_id)
{
drmModeConnector *connector;
@@ -85,9 +98,7 @@ static bool test(int drm_fd, uint32_t connector_id)
ret > 0 ? "success" : strerror(errno));
igt_assert(ret == sizeof(buf) ||
- errno == ETIMEDOUT ||
- (errno == EIO && (is_mst_connector(drm_fd, connector_id) ||
- is_amdgpu_device(drm_fd))));
+ sink_detect_error(drm_fd, connector_id, errno));
close(fd);
--
2.37.1
More information about the igt-dev
mailing list