[igt-dev] [PATCH i-g-t] lib/gpgpu_fill: Implement gpgpu_fillfunc for XEPH

[Zbigniew Kempczyński]

On Tue, Mar 28, 2023 at 02:12:59PM +0100, Matthew Auld wrote:
> On Mon, 27 Mar 2023 at 16:44, Zbigniew Kempczyński
> <zbigniew.kempczynski at intel.com> wrote:
> >
> > From: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
> >
> > Adding xeph_gpgpu_fillfunc to have gpgpu_fill running on XEPH (DG2).
> > On XEPH there's no GPGPU_WALK command, it has COMPUTE_WALK what requires
> > pipeline creation change.
> 
> Just a drive-by-comment, what is XEPH? Also in the patch itself. I
> have only ever seen XEHP and XELP. Is this a typo? s/PH/HP/ ?

You're right, XEHP should be there.

Don't ask me about rationale with using names instead of versioning
strings - it is out of my decision.

--
Zbigniew

> 
> >
> > Shader used in the test was taken from previous generation with
> > adding SWSB dependency tracking. SWSB was added using iga64 automatic
> > dependency generating:
> >
> > iga64 -p=12p5 -Xauto-deps shader.asm
> >
> > Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> > Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>