[igt-dev] [PATCH i-g-t v2 1/9] tests/kms_color: Use legacy LUT for chopping off the lsbs

[Shankar, Uma]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Ville Syrjala
> Sent: Tuesday, April 11, 2023 9:46 PM
> To: igt-dev at lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t v2 1/9] tests/kms_color: Use legacy LUT for chopping
> off the lsbs
> 
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Trying to use an interpolated gamma mode (as is the case currently on eg. icl/tgl) for
> chopping off the lsbs doesn't really work. Use the legacy LUT instead. Also get rid of
> the degamma LUT as that can't even be enabled alognside the legacy LUT on split
> gamma i915 platforms (ivb-skl).

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar at intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  tests/kms_color.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/kms_color.c b/tests/kms_color.c index
> cd03c1354c0a..369dc8057d83 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -504,13 +504,10 @@ static bool test_pipe_ctm(data_t *data,
>  	 * rounding issues and inaccuracies leading to crc mismatch.
>  	 */
>  	if (is_i915_device(data->drm_fd) && memcmp(before, after,
> sizeof(color_t))) {
> -		igt_require(igt_pipe_obj_has_prop(primary->pipe,
> IGT_CRTC_DEGAMMA_LUT));
>  		igt_require(igt_pipe_obj_has_prop(primary->pipe,
> IGT_CRTC_GAMMA_LUT));
> 
> -		degamma_linear = generate_table(data->degamma_lut_size, 1.0);
> -		gamma_linear = generate_table(data->gamma_lut_size, 1.0);
> +		gamma_linear = generate_table(256, 1.0);
> 
> -		set_degamma(data, primary->pipe, degamma_linear);
>  		set_gamma(data, primary->pipe, gamma_linear);
>  	}
> 
> --
> 2.39.2