[igt-dev] [PATCH i-g-t] tests/kms_hdr: Update dmesg error message

Sharma, Swati2 swati2.sharma at intel.com
Fri May 5 15:04:58 UTC 2023


LGTM

Reviewed-by: Swati Sharma <swati2.sharma at intel.com>

On 05-May-23 8:09 PM, Lucas De Marchi wrote:
> On Thu, May 04, 2023 at 05:05:56PM -0700, Lucas De Marchi wrote:
>> Error message changed in the kernel in commit
>> e5eef23e267c ("drm/display: Don't block HDR_OUTPUT_METADATA on
>> unknown EOTF"). We should probably have a better way to get this
>> error, but this should bring it back to a pass.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> ---
>>
>> Still to be tested.... didn't have a machine available to reproduce it
> 
> from CI results:
> 
> igt at kms_hdr@invalid-hdr at pipe-a-dp-1:
>      shard-apl: FAIL (i915#8253) -> PASS
> 
> Lucas De Marchi
> 
>>
>> tests/kms_hdr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
>> index 23f12c14a..cbc0f3a55 100644
>> --- a/tests/kms_hdr.c
>> +++ b/tests/kms_hdr.c
>> @@ -418,7 +418,7 @@ static void test_static_toggle(data_t *data, enum 
>> pipe pipe,
>>     igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 10);
>>     igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 
>> NULL);
>>     if (flags & TEST_INVALID_HDR) {
>> -        igt_assert_eq(system("dmesg|tail -n 1000|grep -E \"EOTF Not 
>> Supported\""), 0);
>> +        igt_assert_eq(system("dmesg|tail -n 1000|grep -E \"Unknown 
>> EOTF [0-9]+\""), 0);
>>         goto cleanup;
>>     }
>>     igt_assert_output_bpc_equal(data->fd, pipe, output->name, 10);
>> -- 
>> 2.40.1
>>


More information about the igt-dev mailing list