[igt-dev] [PATCH i-g-t 1/2] lib/intel_batchbuffer: Add bind/unbind debug for single bo for Xe

[Kumar, Janga Rahul]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Zbigniew
> Kempczynski
> Sent: 12 May 2023 01:06
> To: igt-dev at lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 1/2] lib/intel_batchbuffer: Add bind/unbind debug
> for single bo for Xe
> 
> We're still in early phase of integrating intel-bb infra with Xe so debugging
> information about bind/unbind might be handy. Binding path for single/multiple
> differs so lets add it for single case as it was missing now.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  lib/intel_batchbuffer.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index
> 545d170548..14ed8057e8 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -1313,8 +1313,11 @@ static void __unbind_xe_objects(struct intel_bb *ibb)
>  				 ibb->num_objects, syncs, 2);
>  		free(bind_ops);
>  	} else {
> +		igt_debug("bind: UNMAP\n");
>  		xe_vm_unbind_async(ibb->fd, ibb->vm_id, 0, 0,
>  				   ibb->batch_offset, ibb->size, syncs, 2);
> +		igt_debug("  offset: %llx, size: %llx\n",
> +			  (long long)ibb->batch_offset, (long long)ibb->size);
>  	}
>  	ret = syncobj_wait_err(ibb->fd, &syncs[1].handle, 1, INT64_MAX, 0);
>  	igt_assert_eq(ret, 0);
> @@ -2326,8 +2329,12 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags,
> bool sync)
>  				 ibb->num_objects, syncs, 1);
>  		free(bind_ops);
>  	} else {
> +		igt_debug("bind: MAP\n");
>  		xe_vm_bind_async(ibb->fd, ibb->vm_id, 0, ibb->handle, 0,
>  				 ibb->batch_offset, ibb->size, syncs, 1);
> +		igt_debug("  handle: %u, offset: %llx, size: %llx\n",
> +			  ibb->handle, (long long)ibb->batch_offset,
> +			  (long long)ibb->size);
>  	}
>  	ibb->xe_bound = true;
> 
> --
> 2.34.1

Acked-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>

Thanks,
Rahul