[igt-dev] [PATCHv2 i-g-t 2/4] tests/kms_async_flips: Run the test only once per pipe

[Murthy, Arun R]

> -----Original Message-----
> From: B S, Karthik <karthik.b.s at intel.com>
> Sent: Wednesday, May 17, 2023 12:04 PM
> To: Murthy, Arun R <arun.r.murthy at intel.com>; igt-
> dev at lists.freedesktop.org
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Subject: Re: [PATCHv2 i-g-t 2/4] tests/kms_async_flips: Run the test only once
> per pipe
> 
> 
> On 5/17/2023 9:20 AM, Arun R Murthy wrote:
> > No real reason to iterate over all the outputs here. Just do the test
> > once per pipe.
> >
> > v2: corrected commit message
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Signed-off-by: Arun R Murthy <arun.r.murthy at intel.com>
> > ---
> >   tests/kms_async_flips.c | 25 +++++++++----------------
> >   1 file changed, 9 insertions(+), 16 deletions(-)
> >
> > diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
> > fe27a9ec..1c036426 100644
> > --- a/tests/kms_async_flips.c
> > +++ b/tests/kms_async_flips.c
> > @@ -548,27 +548,20 @@ static void test_crc(data_t *data)
> >
> >   static void run_test(data_t *data, void (*test)(data_t *))
> >   {
> > -	igt_output_t *output;
> > -	enum pipe pipe;
> >   	igt_display_t *display = &data->display;
> >
> > -	for_each_pipe(display, pipe) {
> > -		for_each_valid_output_on_pipe(display, pipe, output) {
> > -			igt_display_reset(display);
> > +	for_each_valid_output_on_pipe(display, data->pipe, data->output) {
> > +		igt_display_reset(display);
> >
> > -			igt_output_set_pipe(output, pipe);
> > -			if (!i915_pipe_output_combo_valid(display))
> > -				continue;
> > +		igt_output_set_pipe(data->output, data->pipe);
> > +		if (!i915_pipe_output_combo_valid(display))
> > +			continue;
> >
> > -			igt_dynamic_f("pipe-%s-%s",
> kmstest_pipe_name(pipe), output->name) {
> > -				data->output = output;
> > -				data->pipe = pipe;
> > -				test(data);
> > -			}
> > +		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data-
> >pipe), data->output->name)
> > +			test(data);
> >
> > -			if (!data->extended)
> > -				break;
> > -		}
> > +		if (!data->extended)
> > +			break;
> 
> Hi,
> 
> Based on discussion on the previous revision, I think it would be better to
> remove this completely and run on all outputs even on regular CI runs?
> 
Ok, Agree will remove this patch.

Thanks and Regards,
Arun R Murthy
--------------------

> Thanks,
> Karthik.B.S
> >   	}
> >   }
> >