[igt-dev] [PATCH i-g-t 2/4] tests/kms_async_flips: Ger rid of i915 specific fb creation

[Murthy, Arun R]

> -----Original Message-----
> From: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Sent: Wednesday, May 17, 2023 4:41 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Murthy, Arun R <arun.r.murthy at intel.com>; Ville Syrjälä
> <ville.syrjala at linux.intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_async_flips: Ger rid of i915
> specific fb creation
> 
> Hi Arun,
> 
> On 2023-05-16 at 11:52:04 +0530, Arun R Murthy wrote:
> > No idea why the test wants to create the fb differently between i915
> > vs. others. Unify it.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Signed-off-by: Arun R Murthy <arun.r.murthy at intel.com>
> > ---
> >  tests/kms_async_flips.c | 25 +++++++++----------------
> >  1 file changed, 9 insertions(+), 16 deletions(-)
> >
> > diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
> > fe27a9ec..1c036426 100644
> > --- a/tests/kms_async_flips.c
> > +++ b/tests/kms_async_flips.c
> > @@ -548,27 +548,20 @@ static void test_crc(data_t *data)
> >
> >  static void run_test(data_t *data, void (*test)(data_t *))  {
> > -	igt_output_t *output;
> > -	enum pipe pipe;
> >  	igt_display_t *display = &data->display;
> >
> > -	for_each_pipe(display, pipe) {
> > -		for_each_valid_output_on_pipe(display, pipe, output) {
> > -			igt_display_reset(display);
> > +	for_each_valid_output_on_pipe(display, data->pipe, data->output) {
> > +		igt_display_reset(display);
> 
> Above change is not described, is it really the same functionality ?
> 
Have updated the patch description in the latest version.
Please review the latest version 2.

Thanks and Regards,
Arun R Murthy
--------------------
> Regards,
> Kamil
> 
> >
> > -			igt_output_set_pipe(output, pipe);
> > -			if (!i915_pipe_output_combo_valid(display))
> > -				continue;
> > +		igt_output_set_pipe(data->output, data->pipe);
> > +		if (!i915_pipe_output_combo_valid(display))
> > +			continue;
> >
> > -			igt_dynamic_f("pipe-%s-%s",
> kmstest_pipe_name(pipe), output->name) {
> > -				data->output = output;
> > -				data->pipe = pipe;
> > -				test(data);
> > -			}
> > +		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data-
> >pipe), data->output->name)
> > +			test(data);
> >
> > -			if (!data->extended)
> > -				break;
> > -		}
> > +		if (!data->extended)
> > +			break;
> >  	}
> >  }
> >
> > --
> > 2.25.1
> >