[igt-dev] [PATCH i-g-t 1/4] tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon May 22 13:25:54 UTC 2023


Hi Maira,

On 2023-04-03 at 10:01:21 -0300, Maíra Canal wrote:
> The subtest "bad-pixel-format" expects that RGB565 rotation is not
> supported for 90 degrees, which is not necessarily true for non-i915
> devices. Therefore, require the device to be i915 before running the
> subtest "bad-pixel-format", as we can only guarantee bad pixel formats
> for i915 devices.
> 
> Signed-off-by: Maíra Canal <mcanal at igalia.com>
> ---
>  tests/kms_rotation_crc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 295aed76..0d7b3962 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -1181,6 +1181,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  
>  	igt_describe("Checking unsupported pixel format for gen9+ with 90 degree of rotation");
>  	igt_subtest_f("bad-pixel-format") {
> +		igt_require(is_i915_device(data.gfx_fd));
------------------------------ ^
Please change this into is_intel_device

Regards,
Kamil

> +
>  		 /* gen11 enables RGB565 rotation for 90/270 degrees.
>  		  * so apart from this, any other gen11+ pixel format
>  		  * can be used which doesn't support 90/270 degree
> -- 
> 2.39.2
> 


More information about the igt-dev mailing list