[igt-dev] [i-g-t 10/20] tests/i915/kms_mmap_write_crc: Avoid closing the closed fd

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed May 24 08:00:36 UTC 2023


Hi,

On 2023-05-16 at 22:20:48 +0530, Bhanuprakash Modem wrote:
> Avoid closing the closed fd.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/i915/kms_mmap_write_crc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/i915/kms_mmap_write_crc.c b/tests/i915/kms_mmap_write_crc.c
> index bc51975f6..2a2526417 100644
> --- a/tests/i915/kms_mmap_write_crc.c
> +++ b/tests/i915/kms_mmap_write_crc.c
> @@ -306,6 +306,5 @@ igt_main_args("n", NULL, NULL, opt_handler, NULL)
>  		close(data.drm_fd);
>  
>  		igt_stop_helper(&hog);
> -		close(data.drm_fd);

Nice catch.

>  	}
>  }
> -- 
> 2.40.0
> 


More information about the igt-dev mailing list