[igt-dev] [PATCH i-g-t 2/2] tests/xe_intel_bb: Skip on platforms without render engine

Dandamudi, Priyanka priyanka.dandamudi at intel.com
Fri May 26 05:41:01 UTC 2023



> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Zbigniew Kempczynski
> Sent: 26 May 2023 01:04 AM
> To: igt-dev at lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 2/2] tests/xe_intel_bb: Skip on platforms
> without render engine
> 
> Running render test on platforms without 3d engine doesn't make sense.
> Use added check and skip on such platforms to avoid the noise.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/xe/xe_intel_bb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/xe/xe_intel_bb.c b/tests/xe/xe_intel_bb.c index
> 35d61608e1..4cdc04345a 100644
> --- a/tests/xe/xe_intel_bb.c
> +++ b/tests/xe/xe_intel_bb.c
> @@ -1168,6 +1168,8 @@ igt_main_args("dpib", NULL, help_str,
> opt_handler, NULL)
>  		full_batch(bops);
> 
>  	igt_subtest_with_dynamic("render") {
> +		igt_require(xe_has_engine_class(xe,
> DRM_XE_ENGINE_CLASS_RENDER));
> +
>  		for (i = 0; i < ARRAY_SIZE(tests); i++) {
>  			const struct test *t = &tests[i];
> 
> --
LGTM
Reviewed-by: Priyanka Dandamudi <Priyanka.dandamudi at intel.com>
> 2.34.1



More information about the igt-dev mailing list