[igt-dev] [PATCH i-g-t v4 06/11] i915/perf_*: better document tests

Mauro Carvalho Chehab mauro.chehab at linux.intel.com
Fri May 26 06:32:29 UTC 2023


On Thu, 25 May 2023 22:42:55 +0200
Kamil Konieczny <kamil.konieczny at linux.intel.com> wrote:

> Hi Mauro,
> 
> On 2023-05-25 at 11:05:30 +0200, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab <mchehab at kernel.org>
> > 
> > Merge data from some ancillary internal documentation to improve
> > i915 perf test descriptions.
> > 
> > This patch was auto-generated via script.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

> >   * SUBTEST: non-zero-reason
> > - * Description: Test that reason field in OA reports is never 0 on Gen8+
> > - * Feature: oa
> > + * Description:
> > + *   Test that reason field in OA reports is never 0 on Gen8+.
> > + *   Test that reason field in OA reports is never 0 on Gen8+  
> ------- ^
> Repeated without ending dot.
> 
> Rest looks good, you can add my r-b if you feel this can be
> corrected later.

I'll fix it now. Basically, "+" needs to be escaped at the regex
I'm using to drop duplicated comment. A single-line change on my
import script fixed it.

I'll merge the change on this patch and add your R-B.

Regards,
Mauro



More information about the igt-dev mailing list