[igt-dev] [PATCH i-g-t] i915/gem_exec_balancer: skip noheartbeat test with GuC

Nirmoy Das nirmoy.das at intel.com
Mon May 29 16:14:22 UTC 2023


On 5/29/2023 2:21 PM, Andrzej Hajda wrote:
> GuC does not support fully updating of persisting contexts, especially
> heartbeat related parameters.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>
> Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>

> ---
> Hi,
>
> This is another case where GuC does not support runtime disabling
> heartbeat. I hope the last one.
>
> Regards
> Andrzej
> ---
>   tests/i915/gem_exec_balancer.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index 3ab0903ac89..004ba9a14fe 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -2938,6 +2938,8 @@ static void noheartbeat(int i915)
>   {
>   	const struct intel_execution_engine2 *e;
>   
> +	igt_require(!gem_using_guc_submission(i915));
> +
>   	/*
>   	 * Check that non-persistent contexts are also cleaned up if we
>   	 * close the context while they are active, but the engine's


More information about the igt-dev mailing list