[igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim
Juha-Pekka Heikkila
juhapekka.heikkila at gmail.com
Wed May 31 08:10:46 UTC 2023
look ok to me. While pushing you could fix typo from commit message,
"PO10" -> "P010".
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
On 29.5.2023 15.11, Swati Sharma wrote:
> To reduce execution time in simulation dropping RGB565 and PO10
> formats (coverage is not compromised, we do have NV12 and RGB888
> formats being validated).
> Also, skipping buffered CRC reusecrcfromlastround() in simulation.
>
> v2: -Add checks inside multiplaneskiproundcheck() and
> reusecrcfromlastround() (JP)
>
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---
> tests/kms_rotation_crc.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 28b4fd27..0a22cc22 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -719,6 +719,16 @@ static bool multiplaneskiproundcheck(data_t *data, planeinfos p[2])
> if (!igt_plane_has_rotation(p[1].plane, p[1].fbinfo->rotation))
> return false;
>
> + if (igt_run_in_simulation() &&
> + (multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_P010 ||
> + multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_RGB565))
> + return false;
> +
> + if (igt_run_in_simulation() &&
> + (multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_P010 ||
> + multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_RGB565))
> + return false;
> +
> return true;
> }
>
> @@ -765,6 +775,9 @@ static bool reusecrcfromlastround(planeinfos p[2], int lastroundp1format,
> int lastroundp0rotation,
> int lastroundp1rotation)
> {
> + if (igt_run_in_simulation())
> + return false;
> +
> if (planarcheck != 1)
> return false;
>
More information about the igt-dev
mailing list