[igt-dev] [RFC PATCH 1/7] include/drm-uapi: Add COLOROP object
Harry Wentland
harry.wentland at amd.com
Thu Nov 2 15:52:20 UTC 2023
On 2023-09-18 05:24, Kamil Konieczny wrote:
> Hi Harry,
>
> On 2023-09-08 at 11:03:09 -0400, Harry Wentland wrote:
>> Signed-off-by: Harry Wentland <harry.wentland at amd.com>
>
> Put here description from cover letter or at least links
> to drm-uapi commits (prefereable lore.kernel.org) with subjects
> cited (as links can break in future).
>
I agree this needs a bit of a description and will be remedied
in the next version, but for the bigger picture shouldn't this
be in the cover letter? If I copy-paste the cover letter here
then why not in every other patch of the series?
(Email patch series still confuse me -_-)
Harry
> Regards,
> Kamil
>
>> Cc: Ville Syrjala <ville.syrjala at linux.intel.com>
>> Cc: Pekka Paalanen <pekka.paalanen at collabora.com>
>> Cc: Simon Ser <contact at emersion.fr>
>> Cc: Harry Wentland <harry.wentland at amd.com>
>> Cc: Melissa Wen <mwen at igalia.com>
>> Cc: Jonas Ådahl <jadahl at redhat.com>
>> Cc: Sebastian Wick <sebastian.wick at redhat.com>
>> Cc: Shashank Sharma <shashank.sharma at amd.com>
>> Cc: Alexander Goins <agoins at nvidia.com>
>> Cc: Joshua Ashton <joshua at froggi.es>
>> Cc: Michel Dänzer <mdaenzer at redhat.com>
>> Cc: Aleix Pol <aleixpol at kde.org>
>> Cc: Xaver Hugl <xaver.hugl at gmail.com>
>> Cc: Victoria Brekenfeld <victoria at system76.com>
>> Cc: Daniel Vetter <daniel at ffwll.ch>
>> Cc: Uma Shankar <uma.shankar at intel.com>
>> Cc: Naseer Ahmed <quic_naseer at quicinc.com>
>> Cc: Christopher Braga <quic_cbraga at quicinc.com>
>> ---
>> include/drm-uapi/drm_mode.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/drm-uapi/drm_mode.h b/include/drm-uapi/drm_mode.h
>> index e4a2570a6058..e7e56150616b 100644
>> --- a/include/drm-uapi/drm_mode.h
>> +++ b/include/drm-uapi/drm_mode.h
>> @@ -626,6 +626,7 @@ struct drm_mode_connector_set_property {
>> #define DRM_MODE_OBJECT_FB 0xfbfbfbfb
>> #define DRM_MODE_OBJECT_BLOB 0xbbbbbbbb
>> #define DRM_MODE_OBJECT_PLANE 0xeeeeeeee
>> +#define DRM_MODE_OBJECT_COLOROP 0xfafafafa
>> #define DRM_MODE_OBJECT_ANY 0
>>
>> struct drm_mode_obj_get_properties {
>> --
>> 2.42.0
>>
More information about the igt-dev
mailing list