[igt-dev] [PATCH v2 37/64] drm-uapi/xe: Differentiate WAIT_OP from WAIT_MASK
Francois Dugast
francois.dugast at intel.com
Fri Nov 3 14:43:32 UTC 2023
From: Rodrigo Vivi <rodrigo.vivi at intel.com>
Align with kernel commit ("drm/xe/uapi: Differentiate WAIT_OP from WAIT_MASK")
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
include/drm-uapi/xe_drm.h | 41 ++++++++++++++++++++-------------------
lib/xe/xe_ioctl.c | 8 ++++----
2 files changed, 25 insertions(+), 24 deletions(-)
diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
index cadb1e2b1..b546e42a5 100644
--- a/include/drm-uapi/xe_drm.h
+++ b/include/drm-uapi/xe_drm.h
@@ -1123,22 +1123,22 @@ struct drm_xe_exec_queue_get_property {
* Returns to user on user fence completion or timeout.
*
* The wait @op can be:
- * - %DRM_XE_UFENCE_WAIT_EQ
- * - %DRM_XE_UFENCE_WAIT_NEQ
- * - %DRM_XE_UFENCE_WAIT_GT
- * - %DRM_XE_UFENCE_WAIT_GTE
- * - %DRM_XE_UFENCE_WAIT_LT
- * - %DRM_XE_UFENCE_WAIT_LTE
+ * - %DRM_XE_UFENCE_WAIT_OP_EQ
+ * - %DRM_XE_UFENCE_WAIT_OP_NEQ
+ * - %DRM_XE_UFENCE_WAIT_OP_GT
+ * - %DRM_XE_UFENCE_WAIT_OP_GTE
+ * - %DRM_XE_UFENCE_WAIT_OP_LT
+ * - %DRM_XE_UFENCE_WAIT_OP_LTE
*
* The wait @flags can be:
* - %DRM_XE_UFENCE_WAIT_FLAG_SOFT_OP
* - %DRM_XE_UFENCE_WAIT_FLAG_ABSTIME
*
* The wait @mask can be:
- * - %DRM_XE_UFENCE_WAIT_U8
- * - %DRM_XE_UFENCE_WAIT_U16
- * - %DRM_XE_UFENCE_WAIT_U32
- * - %DRM_XE_UFENCE_WAIT_U64
+ * - %DRM_XE_UFENCE_WAIT_MASK_U8
+ * - %DRM_XE_UFENCE_WAIT_MASK_U16
+ * - %DRM_XE_UFENCE_WAIT_MASK_U32
+ * - %DRM_XE_UFENCE_WAIT_MASK_U64
*
*/
struct drm_xe_wait_user_fence {
@@ -1150,12 +1150,12 @@ struct drm_xe_wait_user_fence {
*/
__u64 addr;
-#define DRM_XE_UFENCE_WAIT_EQ 0
-#define DRM_XE_UFENCE_WAIT_NEQ 1
-#define DRM_XE_UFENCE_WAIT_GT 2
-#define DRM_XE_UFENCE_WAIT_GTE 3
-#define DRM_XE_UFENCE_WAIT_LT 4
-#define DRM_XE_UFENCE_WAIT_LTE 5
+#define DRM_XE_UFENCE_WAIT_OP_EQ 0x0
+#define DRM_XE_UFENCE_WAIT_OP_NEQ 0x1
+#define DRM_XE_UFENCE_WAIT_OP_GT 0x2
+#define DRM_XE_UFENCE_WAIT_OP_GTE 0x3
+#define DRM_XE_UFENCE_WAIT_OP_LT 0x4
+#define DRM_XE_UFENCE_WAIT_OP_LTE 0x5
/** @op: wait operation (type of comparison) */
__u16 op;
@@ -1170,12 +1170,13 @@ struct drm_xe_wait_user_fence {
/** @value: compare value */
__u64 value;
-#define DRM_XE_UFENCE_WAIT_U8 0xffu
-#define DRM_XE_UFENCE_WAIT_U16 0xffffu
-#define DRM_XE_UFENCE_WAIT_U32 0xffffffffu
-#define DRM_XE_UFENCE_WAIT_U64 0xffffffffffffffffu
+#define DRM_XE_UFENCE_WAIT_MASK_U8 0xffu
+#define DRM_XE_UFENCE_WAIT_MASK_U16 0xffffu
+#define DRM_XE_UFENCE_WAIT_MASK_U32 0xffffffffu
+#define DRM_XE_UFENCE_WAIT_MASK_U64 0xffffffffffffffffu
/** @mask: comparison mask */
__u64 mask;
+
/**
* @timeout: how long to wait before bailing, value in nanoseconds.
* Without DRM_XE_UFENCE_WAIT_FLAG_ABSTIME flag set (relative timeout)
diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
index e928148ee..5d4f2fcd8 100644
--- a/lib/xe/xe_ioctl.c
+++ b/lib/xe/xe_ioctl.c
@@ -422,10 +422,10 @@ int64_t xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
{
struct drm_xe_wait_user_fence wait = {
.addr = to_user_pointer(addr),
- .op = DRM_XE_UFENCE_WAIT_EQ,
+ .op = DRM_XE_UFENCE_WAIT_OP_EQ,
.flags = !eci ? DRM_XE_UFENCE_WAIT_FLAG_SOFT_OP : 0,
.value = value,
- .mask = DRM_XE_UFENCE_WAIT_U64,
+ .mask = DRM_XE_UFENCE_WAIT_MASK_U64,
.timeout = timeout,
.num_engines = eci ? 1 :0,
.instances = eci ? to_user_pointer(eci) : 0,
@@ -454,10 +454,10 @@ int64_t xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
{
struct drm_xe_wait_user_fence wait = {
.addr = to_user_pointer(addr),
- .op = DRM_XE_UFENCE_WAIT_EQ,
+ .op = DRM_XE_UFENCE_WAIT_OP_EQ,
.flags = !eci ? DRM_XE_UFENCE_WAIT_FLAG_SOFT_OP | DRM_XE_UFENCE_WAIT_FLAG_ABSTIME : 0,
.value = value,
- .mask = DRM_XE_UFENCE_WAIT_U64,
+ .mask = DRM_XE_UFENCE_WAIT_MASK_U64,
.timeout = timeout,
.num_engines = eci ? 1 : 0,
.instances = eci ? to_user_pointer(eci) : 0,
--
2.34.1
More information about the igt-dev
mailing list