[igt-dev] [PATCH i-g-t 1/2] XE2: LNL: adding Blt command support for Lunarlake

[Jahagirdar, Akshata]

Will fix this,
Thanks

-----Original Message-----
From: Kamil Konieczny <kamil.konieczny at linux.intel.com> 
Sent: Wednesday, November 8, 2023 6:37 AM
To: Jahagirdar, Akshata <akshata.jahagirdar at intel.com>
Cc: igt-dev at lists.freedesktop.org; Siddiqui, Ayaz A <ayaz.siddiqui at intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] XE2: LNL: adding Blt command support for Lunarlake

Hi,

please correct subject of you mail/patch, now it reads:

[PATCH i-g-t 1/2] XE2: LNL: adding Blt command support for Lunarlake

but it should be like:

[PATCH i-g-t 1/2] lib: adding Blt command support for Lunarlake

Add (short) description here what did you added, for example what command did you add.

Add proper From: and s-o-b:, now I see:

Author: Jahagirdar, Akshata <akshata.jahagirdar at intel.com>

it should be:

Author: Akshata Jahagirdar <akshata.jahagirdar at intel.com>

At the end of patch add s-o-b like:

Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar at intel.com>

Regards,
Kamil

On 2023-11-08 at 11:57:05 -0800, Jahagirdar, Akshata wrote:
> ---
>  lib/intel_cmds_info.c   | 24 ++++++++++++++++++++++++
>  lib/intel_cmds_info.h   |  1 +
>  lib/intel_device_info.c |  2 +-
>  3 files changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/intel_cmds_info.c b/lib/intel_cmds_info.c index 
> 2e51ec081..fc3554271 100644
> --- a/lib/intel_cmds_info.c
> +++ b/lib/intel_cmds_info.c
> @@ -67,6 +67,22 @@ static const struct blt_cmd_info
>  						 BLT_CMD_EXTENDED |
>  						 BLT_CMD_SUPPORTS_COMPRESSION);
>  
> +static const struct blt_cmd_info				
> +		xe2_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
> +						 BIT(T_LINEAR) |
> +						 BIT(T_XMAJOR) |
> +						 BIT(T_TILE4)  |
> +						 BIT(T_TILE64),
> +						 BLT_CMD_EXTENDED |
> +						 BLT_CMD_SUPPORTS_COMPRESSION);
> +
> +static const struct blt_cmd_info
> +		xe2_xy_fast_copy = BLT_INFO(XY_FAST_COPY,
> +					    BIT(T_LINEAR) |
> +					    BIT(T_XMAJOR) |
> +					    BIT(T_TILE4)  |
> +					    BIT(T_TILE64));
> +
>  static const struct blt_cmd_info
>  		mtl_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
>  						 BIT(T_LINEAR) |
> @@ -169,6 +185,14 @@ const struct intel_cmds_info gen12_pvc_cmds_info = {
>  	}
>  };
>  
> +
> +const struct intel_cmds_info xe2_cmds_info  = {
> +	.blt_cmds = {
> +		[XY_FAST_COPY] = &xe2_xy_fast_copy,
> +		[XY_BLOCK_COPY] = &xe2_xy_block_copy,
> +	}
> +};
> +
>  const struct blt_cmd_info *blt_get_cmd_info(const struct intel_cmds_info *cmds_info,
>  					    enum blt_cmd_type cmd)
>  {
> diff --git a/lib/intel_cmds_info.h b/lib/intel_cmds_info.h index 
> f9e3932d1..0a83b6a44 100644
> --- a/lib/intel_cmds_info.h
> +++ b/lib/intel_cmds_info.h
> @@ -55,6 +55,7 @@ extern const struct intel_cmds_info gen12_cmds_info;  
> extern const struct intel_cmds_info gen12_dg2_cmds_info;  extern const 
> struct intel_cmds_info gen12_mtl_cmds_info;  extern const struct 
> intel_cmds_info gen12_pvc_cmds_info;
> +extern const struct intel_cmds_info xe2_cmds_info;
>  
>  #define for_each_tiling(__tiling) \
>  	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++) 
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c index 
> 34817f7b6..a669797c3 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -511,7 +511,7 @@ static const struct intel_device_info intel_lunarlake_info = {
>  	.has_4tile = true,
>  	.is_lunarlake = true,
>  	.codename = "lunarlake",
> -	.cmds_info = &gen12_pvc_cmds_info,
> +	.cmds_info = &xe2_cmds_info,
>  };
>  
>  static const struct pci_id_match intel_device_match[] = {
> --
> 2.34.1
>