[igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner checks

[Saarinen, Jani]

Hi,
> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Ville Syrjälä
> Sent: Wednesday, November 15, 2023 10:35 AM
> To: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Cc: igt-dev at lists.freedesktop.org
> Subject: Re: [igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner checks
> 
> On Mon, Nov 13, 2023 at 01:49:29PM +0530, Bhanuprakash Modem wrote:
> > Bigjoiner will come in the picture when the resolution > 5K or clock >
> > max dot-clock. Add a support to check the selected mode clock is
> > greater than the max dot-clock.
> >
> > V2: - Limit the bigjoiner checks to intel hardware
> >
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> > Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> > ---
> >  tests/kms_flip.c | 18 +++++++++++-------
> >  1 file changed, 11 insertions(+), 7 deletions(-)
> >
> > diff --git a/tests/kms_flip.c b/tests/kms_flip.c index
> > fc7cee050..d34596599 100755
> > --- a/tests/kms_flip.c
> > +++ b/tests/kms_flip.c
> <snip>
> > @@ -2136,6 +2139,7 @@ igt_main_args("e", NULL, help_str, opt_handler,
> NULL)
> >  			for (i = 0; i < sizeof(tests) / sizeof(tests[0]); i++)
> >  				tests[i].flags &= ~(TEST_CHECK_TS |
> TEST_VBLANK_EXPIRED_SEQ);
> >  		}
> > +		max_dotclock = igt_get_max_dotclock(drm_fd);
> 
> That seems to have broken the test for !display platforms (bat-atsm-1).
We were just trying to figure out what has happened on  https://intel-gfx-ci.01.org/tree/drm-tip/bat-atsm-1.html as was also visible on 
Linux next https://intel-gfx-ci.01.org/tree/linux-next/bat-atsm-1.html .

But thanks Ville commenting that this is about IGT. 


> 
> >  	}
> >
> >  	igt_describe("Tests that nonblocking reading fails correctly");
> > --
> > 2.40.0
> 
> --
> Ville Syrjälä
> Intel