[igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner checks

[Saarinen, Jani]

Hi, 
> -----Original Message-----
> From: Saarinen, Jani
> Sent: Wednesday, November 15, 2023 10:56 AM
> To: Ville Syrjälä <ville.syrjala at linux.intel.com>; Modem, Bhanuprakash
> <Bhanuprakash.Modem at intel.com>
> Cc: igt-dev at lists.freedesktop.org
> Subject: RE: [igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner checks
> 
> Hi,
> > -----Original Message-----
> > From: Saarinen, Jani
> > Sent: Wednesday, November 15, 2023 10:47 AM
> > To: Ville Syrjälä <ville.syrjala at linux.intel.com>; Modem, Bhanuprakash
> > <Bhanuprakash.Modem at intel.com>
> > Cc: igt-dev at lists.freedesktop.org
> > Subject: RE: [igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner
> > checks
> >
> > Hi,
> > > -----Original Message-----
> > > From: igt-dev <igt-dev-bounces at lists.freedesktop.org
> > > <mailto:igt-dev-bounces at lists.freedesktop.org> > On Behalf Of Ville
> > > Syrjälä
> > > Sent: Wednesday, November 15, 2023 10:35 AM
> > > To: Modem, Bhanuprakash <bhanuprakash.modem at intel.com
> > > <mailto:bhanuprakash.modem at intel.com> >
> > > Cc: igt-dev at lists.freedesktop.org
> > > <mailto:igt-dev at lists.freedesktop.org>
> > > Subject: Re: [igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner
> > > checks
> > >
> > > On Mon, Nov 13, 2023 at 01:49:29PM +0530, Bhanuprakash Modem wrote:
> > > > Bigjoiner will come in the picture when the resolution > 5K or
> > > > clock
> > > > > max dot-clock. Add a support to check the selected mode clock is
> > > > greater than the max dot-clock.
> > > >
> > > > V2: - Limit the bigjoiner checks to intel hardware
> > > >
> > > > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com
> > > > <mailto:bhanuprakash.modem at intel.com> >
> > > > Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com
> > > > <mailto:ankit.k.nautiyal at intel.com> >
> > > > ---
> > > >  tests/kms_flip.c | 18 +++++++++++-------
> > > >  1 file changed, 11 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c index
> > > > fc7cee050..d34596599 100755
> > > > --- a/tests/kms_flip.c
> > > > +++ b/tests/kms_flip.c
> > > <snip>
> > > > @@ -2136,6 +2139,7 @@ igt_main_args("e", NULL, help_str,
> > > > opt_handler,
> > > NULL)
> > > >  			for (i = 0; i < sizeof(tests) / sizeof(tests[0]); i++)
> > > >  				tests[i].flags &= ~(TEST_CHECK_TS |
> > > TEST_VBLANK_EXPIRED_SEQ);
> > > >  		}
> > > > +		max_dotclock = igt_get_max_dotclock(drm_fd);
> > >
> > > That seems to have broken the test for !display platforms (bat-atsm-1).
> > We were just trying to figure out what has happened on
> > https://intel-gfx-
> > <https://intel-gfx-ci.01.org/tree/drm-tip/bat-atsm-1.html>
> > ci.01.org/tree/drm-tip/bat-atsm-1.html as was also visible on Linux
> > next https://intel-gfx-ci.01.org/tree/linux-next/bat-atsm-1.html .
> >
> > But thanks Ville commenting that this is about IGT.
> Indeed IGT changed between skip and fail (bolded) 328c5873b
This was with Linux-next actually and on BAT this was for IGT's
f7ae24e64 syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED | WAIT_AVAILABLE ===(IGT_7585)===
^^^new
8c244b802 tests/kms_setmode: Fix Bigjoiner checks
3d5cd7d99 tests/kms_flip: Fix Bigjoiner checks
a6ca34472 tests/i915/kms_big_joiner: Fix Bigjoiner checks
9d45e7aae lib/igt_kms: s/is_i915_device/is_intel_device
53d1677a8 tests: s/i915_pipe_output_combo_valid/intel_pipe_output_combo_valid/
30e6ded90 Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" ===(IGT_7584)===
f6f590334 syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE

NO git-log.txt ===(IGT_7583)===

453b9df12 tests/intel/xe_exec_queue_property: Add scheduler exec queue set property ===(IGT_7582)===
^^ old

> tests/intel/xe_exec_queue_property: Negative tests for get exec_queue property
> ioctl ===(IGT_7588)===
> 
> bec435c24 tests/intel/kms_dsc: remove redundant documentation
> ===(IGT_7587)=== 37c3d2d4c tests/intel/kms_dsc: add test to validate fractional
> bpp with input bpc a83d0d03c tests/intel/kms_dsc: enable validation for vdsc
> fractional bpp
> 40bb84ee2 lib/dsc: add helpers for vdsc fractional bpp debugfs entry
> d99e8f119 lib/dsc: fix documentation style
> 
> c422858f8 tests/xe_evict_ccs: Disable compression on platforms without flatccs
> ===(IGT_7586)===
> 
> f7ae24e64 syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED |
> WAIT_AVAILABLE ===(IGT_7585)===
> 8c244b802 tests/kms_setmode: Fix Bigjoiner checks
> 3d5cd7d99 tests/kms_flip: Fix Bigjoiner checks
> a6ca34472 tests/i915/kms_big_joiner: Fix Bigjoiner checks 9d45e7aae
> lib/igt_kms: s/is_i915_device/is_intel_device
> 53d1677a8 tests:
> s/i915_pipe_output_combo_valid/intel_pipe_output_combo_valid/
> 
> 30e6ded90 Revert "syncobj_timeline: don't expect EINVAL for
> WAIT_UNSUBMITTED, | WAIT_AVAILABLE" ===(IGT_7584)===
> f6f590334 syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, |
> WAIT_AVAILABLE
> 
> NO git-log.txt ===(IGT_7583)===
> 
> 453b9df12 tests/intel/xe_exec_queue_property: Add scheduler exec queue set
> property ===(IGT_7582)=== 60f199d7b tests/intel/xe_exec_queue_property: Add
> exec queue set property tests
> 897748a32 tests/intel/xe_waitfence: Add invalid-engine subtest
> ===(IGT_7581)===
> >
> >
> > >
> > > >  	}
> > > >
> > > >  	igt_describe("Tests that nonblocking reading fails correctly");
> > > > --
> > > > 2.40.0
> > >
> > > --
> > > Ville Syrjälä
> > > Intel