[igt-dev] [PATCH v2] tests/amdgpu: add VPE tests

[Kamil Konieczny]

Hi Yu,
On 2023-11-13 at 02:47:55 +0000, Yu, Lang wrote:
> [AMD Official Use Only - General]
> 
> >-----Original Message-----
> >From: Prosyak, Vitaly <Vitaly.Prosyak at amd.com>
> >Sent: Monday, November 13, 2023 6:37 AM
> >To: Yu, Lang <Lang.Yu at amd.com>; igt-dev at lists.freedesktop.org
> >Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>; Deucher, Alexander
> ><Alexander.Deucher at amd.com>; Prosyak, Vitaly <Vitaly.Prosyak at amd.com>;
> >Chiu, Solomon <Solomon.Chiu at amd.com>; Liu, Leo <Leo.Liu at amd.com>
> >Subject: Re: [PATCH v2] tests/amdgpu: add VPE tests
> >
> >Added Leo.
> >
> >Hi Lang,
> >
> >Please, use the checkpatch.pl and fix formatting errors, for example,
> 
> Actually, it is strange to use checkpatch.pl to check igt patches.
> How do you know the igt test developer is familiar with linux kernel tools?
> Anyway I will check the patch  with checkpatch.pl.
> 

It is a tool which helps with keeping source code in shape, instead of
reinventing our own tool it is better to use it. Some of its errors or
warnings may be ignored but generally I find it usefull.

Regards,
Kamil

> >
> >vprosyak at desktop-host:~/src/igt-gpu-tools$ ../linux/scripts/checkpatch.pl -f --no-
> >tree /home/vprosyak/src/igt-gpu-tools/tests/amdgpu/amd_vpe.c
> >ERROR: code indent should use tabs where possible
> >#54: FILE: /home/vprosyak/src/igt-gpu-tools/tests/amdgpu/amd_vpe.c:54:
> >+                                 struct mmd_context *context)$
> >
> >WARNING: please, no spaces at the start of a line
> >#54: FILE: /home/vprosyak/src/igt-gpu-tools/tests/amdgpu/amd_vpe.c:54:
> >+                                 struct mmd_context *context)$
> >
[...]