[igt-dev] [PATCH i-g-t 4/5] scripts/test_list.py: fix indent at get_subtests()
Mauro Carvalho Chehab
mauro.chehab at linux.intel.com
Tue Nov 28 10:48:59 UTC 2023
From: Mauro Carvalho Chehab <mchehab at kernel.org>
The indent there is wrong, causing this warning:
scripts/test_list.py:1041:46: W0631: Using possibly undefined loop variable 'test' (undefined-loop-variable)
This issue also affects testlist generation, as tests will be
missing there.
Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
---
scripts/test_list.py | 54 ++++++++++++++++++++++----------------------
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/scripts/test_list.py b/scripts/test_list.py
index 79b48813171b..3954e883ada3 100644
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -1038,43 +1038,43 @@ class TestList:
subtest_array += self.expand_subtest(fname, test_name, test, True)
- subtest_array.sort(key = lambda x : x.get('_summary_'))
+ subtest_array.sort(key = lambda x : x.get('_summary_'))
- for subtest in subtest_array:
- if self.__filter_subtest(self.doc[test], subtest, True):
- continue
+ for subtest in subtest_array:
+ if self.__filter_subtest(self.doc[test], subtest, True):
+ continue
- if sort_field:
- if sort_field in subtest:
- if expand:
- test_list = expand.split(subtest[sort_field])
+ if sort_field:
+ if sort_field in subtest:
+ if expand:
+ test_list = expand.split(subtest[sort_field])
- for test_elem in test_list:
- if test_elem not in subtests:
- subtests[test_elem] = []
- if order:
- subtests[test_elem].append((subtest["_summary_"], test_list))
- else:
- subtests[test_elem].append(subtest["_summary_"])
+ for test_elem in test_list:
+ if test_elem not in subtests:
+ subtests[test_elem] = []
+ if order:
+ subtests[test_elem].append((subtest["_summary_"], test_list))
+ else:
+ subtests[test_elem].append(subtest["_summary_"])
+ else:
+ if subtest[sort_field] not in subtests:
+ subtests[subtest[sort_field]] = []
+ if order:
+ subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]]))
+ else:
+ subtests[subtest[sort_field]].append(subtest["_summary_"])
else:
- if subtest[sort_field] not in subtests:
- subtests[subtest[sort_field]] = []
- if order:
- subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]]))
- else:
- subtests[subtest[sort_field]].append(subtest["_summary_"])
+ if order:
+ subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]]))
+ else:
+ subtests[""].append(subtest["_summary_"])
+
else:
if order:
subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]]))
else:
subtests[""].append(subtest["_summary_"])
- else:
- if order:
- subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]]))
- else:
- subtests[""].append(subtest["_summary_"])
-
if order:
for group, tests in subtests.items():
prefix_tests = []
--
2.42.0
More information about the igt-dev
mailing list