[igt-dev] [PATCH i-g-t] intel/xe_exec_store.c: Fix the check for num of placements in store_all.

[Kamil Konieczny]

Hi Sai,

On 2023-11-29 at 15:56:28 +0530, sai.gowtham.ch at intel.com wrote:

I have only few nits, first about subject:

[PATCH i-g-t] intel/xe_exec_store.c: Fix the check for num of placements in store_all.

Please put version info in your patch, do not use ".c" at end of filename,
remove final dot. It should read like:

[PATCH v3 i-g-t] intel/xe_exec_store: Fix the check for num of placements in store_all

> From: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> 
> Adjust the store_all execution with dynamic subtest, so that test will
> skip the engines with no instances and executes on the engines with instances.
> 

Add to Cc Rahul as he sent review:
Cc: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>

Regards,
Kamil

> ---
>  tests/intel/xe_exec_store.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/xe_exec_store.c b/tests/intel/xe_exec_store.c
> index 9c14bfd14..95c678bf7 100644
> --- a/tests/intel/xe_exec_store.c
> +++ b/tests/intel/xe_exec_store.c
> @@ -245,7 +245,8 @@ static void store_all(int fd, int gt, int class)
>  		eci[num_placements++] = *hwe;
>  	}
>  
> -	igt_require(num_placements);
> +	igt_skip_on_f(!num_placements, "Engine class:%d gt:%d not enabled on this platform\n",
> +			class, gt);
>  
>  	for (i = 0; i < num_placements; i++) {
>  		struct drm_xe_exec_queue_create create = {
> @@ -304,10 +305,13 @@ igt_main
>  	igt_subtest("basic-store")
>  		store(fd);
>  
> -	igt_subtest("basic-all") {
> +	igt_subtest_with_dynamic("basic-all") {
>  		xe_for_each_gt(fd, gt)
> -			xe_for_each_hw_engine_class(class)
> -				store_all(fd, gt, class);
> +			xe_for_each_hw_engine_class(class) {
> +				igt_dynamic_f("class-%d", class) {
> +					store_all(fd, gt, class);
> +				}
> +			}
>  	}
>  
>  	igt_subtest("cachelines")
> -- 
> 2.39.1
>