[igt-dev] [PATCH i-g-t v2 03/13] lib/gpu_cmds: Reorder if/else ladder according to IP version
Lucas De Marchi
lucas.demarchi at intel.com
Wed Oct 4 03:10:13 UTC 2023
Make it easier to follow the flow by following the convention of "latest
platform earlier".
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
---
lib/gpu_cmds.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 648451f74..0fd8f8213 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -270,17 +270,15 @@ fill_binding_table(struct intel_bb *ibb, struct intel_buf *buf)
binding_table = intel_bb_ptr(ibb);
intel_bb_ptr_add(ibb, 64);
- if (IS_GEN7(devid))
- binding_table[0] = gen7_fill_surface_state(ibb, buf,
- SURFACEFORMAT_R8_UNORM, 1);
-
- else if (intel_graphics_ver(devid) >= IP_VER(12, 50))
+ if (intel_graphics_ver(devid) >= IP_VER(12, 50))
binding_table[0] = xehp_fill_surface_state(ibb, buf,
SURFACEFORMAT_R8_UNORM, 1);
-
- else
+ else if (intel_graphics_ver(devid) >= IP_VER(8, 0))
binding_table[0] = gen8_fill_surface_state(ibb, buf,
SURFACEFORMAT_R8_UNORM, 1);
+ else
+ binding_table[0] = gen7_fill_surface_state(ibb, buf,
+ SURFACEFORMAT_R8_UNORM, 1);
return binding_table_offset;
}
--
2.40.1
More information about the igt-dev
mailing list