[igt-dev] [PATCH i-g-t v2 05/13] lib/gpu_cmds: Reduce scope of xehp_fill_surface_state()

Lucas De Marchi lucas.demarchi at intel.com
Wed Oct 4 03:10:15 UTC 2023


gpu_cmds.h is the interface to other igt components: don't use it
to declare functions not supposed to be used from outside.

Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
---
 lib/gpu_cmds.c | 8 +++++++-
 lib/gpu_cmds.h | 6 ------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 83d2302f9..e53580e65 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -25,6 +25,12 @@
 #include "gpu_cmds.h"
 #include "intel_mocs.h"
 
+static uint32_t
+xehp_fill_surface_state(struct intel_bb *ibb,
+			struct intel_buf *buf,
+			uint32_t format,
+			int is_dst);
+
 uint32_t
 gen7_fill_curbe_buffer_data(struct intel_bb *ibb, uint8_t color)
 {
@@ -873,7 +879,7 @@ xehp_fill_interface_descriptor(struct intel_bb *ibb,
 	idd->desc5.num_threads_in_tg = 1;
 }
 
-uint32_t
+static uint32_t
 xehp_fill_surface_state(struct intel_bb *ibb,
 			struct intel_buf *buf,
 			uint32_t format,
diff --git a/lib/gpu_cmds.h b/lib/gpu_cmds.h
index b7ed64f84..5ac007cc4 100644
--- a/lib/gpu_cmds.h
+++ b/lib/gpu_cmds.h
@@ -116,12 +116,6 @@ xehp_fill_interface_descriptor(struct intel_bb *ibb,
 			       size_t size,
 			       struct xehp_interface_descriptor_data *idd);
 
-uint32_t
-xehp_fill_surface_state(struct intel_bb *ibb,
-			struct intel_buf *buf,
-			uint32_t format,
-			int is_dst);
-
 void
 xehp_emit_state_compute_mode(struct intel_bb *ibb);
 
-- 
2.40.1



More information about the igt-dev mailing list