[igt-dev] [PATCH i-g-t v8 2/6] tests/intel/xe_create: extend massive subtest to multi-gpu

[Zbigniew Kempczyński]

On Wed, Oct 04, 2023 at 06:49:38PM +0200, Kamil Konieczny wrote:
> Sample code extends existing create-massive-size subtest to run
> on multi-GPUs boards. This will currently work only with
> --drivers or IGT_DRIVERS options selecting at least two dGPU

s/IGT_DRIVERS/IGT_DEVICE/

Rest looks good to me.

With above fixed:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
--
Zbigniew

> cards.
> 
> v2: Fixed bug in opening wrong multi-gpu device (Zbigniew)
> v3: revert to use filter count, add require for xe, change
>     subtest description
> v4: correct description
> 
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/intel/xe_create.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
> index 8d845e5c8..ee970450f 100644
> --- a/tests/intel/xe_create.c
> +++ b/tests/intel/xe_create.c
> @@ -12,6 +12,7 @@
>  #include <string.h>
>  
>  #include "igt.h"
> +#include "igt_device_scan.h"
>  #include "xe_drm.h"
>  #include "xe/xe_ioctl.h"
>  #include "xe/xe_query.h"
> @@ -191,6 +192,13 @@ static void create_execqueues(int fd, enum exec_queue_destroy ed)
>   * Test category: functionality test
>   * Description: Verifies xe bo create returns expected error code on massive
>   *              buffer sizes.
> + *
> + * SUBTEST: multigpu-create-massive-size
> + * Functionality: ioctl
> + * Test category: functionality test
> + * Feature: multigpu
> + * Description: Verifies xe bo create with massive buffer sizes runs correctly
> + *		on two or more GPUs.
>   */
>  static void create_massive_size(int fd)
>  {
> @@ -228,6 +236,23 @@ igt_main
>  		create_massive_size(xe);
>  	}
>  
> +	igt_subtest("multigpu-create-massive-size") {
> +		int gpu_filter_count = igt_device_filter_count();
> +
> +		igt_require(xe > 0);
> +		igt_require(gpu_filter_count >= 2);
> +		igt_multi_fork(child, gpu_filter_count) {
> +			int gpu_fd;
> +
> +			gpu_fd = child ? __drm_open_driver_another(child, DRIVER_XE) : drm_reopen_driver(xe);
> +			igt_assert_f(gpu_fd > 0, "cannot open gpu-%d, errno=%d\n", child, errno);
> +
> +			create_massive_size(gpu_fd);
> +			drm_close_driver(gpu_fd);
> +		}
> +		igt_waitchildren();
> +	}
> +
>  	igt_fixture
>  		drm_close_driver(xe);
>  }
> -- 
> 2.42.0
>