[igt-dev] [PATCH i-g-t v3 00/13] Adapt copy commands for Xe2

[Lucas De Marchi]

On Wed, Oct 04, 2023 at 08:49:09AM -0700, Lucas De Marchi wrote:
>A few copy commands changed for Xe2, mainly adding or moving the bits
>used for MOCS. This adapts the places we are manually adding the
>commands in the batch buffer, the gpu_cmds and the intel_blt libraries.
>
>Missing here is the conversion of lib/intel_batchbuffer.c. I had
>understood that intel_batchbuffer would end up using the new intel_blt.
>So, it may just be that we have some patches being cooked for that. Or
>I understood it wrong. Anyway, it doesn't seem good that we have
>basically 3 ways to do the same thing.
>
>Also it seems that this is the first time we are updating intel_blt for
>a platform with a breaking change. I used 2 different approaches in how
>to adapt the struct: one for xy-block-copy/xy-fast-copy and another for
>ctrl-surf-copy. The reason is that for the former there was just a minor
>change and the latter basically rewrites all the dwords. Going forward I
>think we should keep applying small deltas to at most 1 or 2 breaking
>changes, otherwise it makes it harder to read.
>
>v2: Provide fixes according to the feedback in v1
>v3:
>  - Fix build: for some reason ninja was caching tests/intel/gem_ccs.o,
>    so it was not getting rebuilt
>  - Use mocs index 4 for WB (depends on kernel patch)
>

Patches applied. Thanks for the reviews

Lucas De Marchi