[igt-dev] [PATCH igt 1/2] tools/msm_dp_compliance: Small arg parsing cleanup

Abhinav Kumar quic_abhinavk at quicinc.com
Thu Oct 19 10:40:04 UTC 2023


Reviving this:

On 12/8/2021 11:22 AM, Rob Clark wrote:
> From: Rob Clark <robdclark at chromium.org>
> 
> Signed-off-by: Rob Clark <robdclark at chromium.org>

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

Nit: shouldnt the patch prefix be "PATCH i-g-t" ?

We will test this out next week and land this.

> ---
>   tools/msm_dp_compliance.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/msm_dp_compliance.c b/tools/msm_dp_compliance.c
> index 5e491c89..a15a8dd9 100644
> --- a/tools/msm_dp_compliance.c
> +++ b/tools/msm_dp_compliance.c
> @@ -629,7 +629,9 @@ static const char optstr[] = "hi";
>   static void __attribute__((noreturn)) usage(char *name, char opt)
>   {
>   	igt_info("usage: %s [-hi]\n", name);
> -	igt_info("\t-i\tdump info\n");
> +	igt_info("\t-h, --help           - print this usage message");
> +	igt_info("\t--help-description   - print test description");
> +	igt_info("\t-i, --info           - dump info\n");
>   	igt_info("\tDefault is to respond to Qd980 tests\n");
>   	exit((opt != 'h') ? -1 : 0);
>   }
> @@ -709,6 +711,7 @@ int main(int argc, char **argv)
>   	struct option long_opts[] = {
>   		{"help-description", 0, 0, HELP_DESCRIPTION},
>   		{"help", 0, 0, 'h'},
> +		{"info", 0, 0, 'i'},
>   	};
>   
>   	enter_exec_path(argv);


More information about the igt-dev mailing list