[igt-dev] [PATCH i-g-t] lib/igt_kmod: Remove wrong note regarding dependencies

Lucas De Marchi lucas.demarchi at intel.com
Thu Oct 19 18:50:19 UTC 2023


igt_kmod_load() uses libkmod's kmod_module_probe_insert_module() which
handles hard and soft dependencies. There's no need load them before
calling this function.

While at it, move the "Returns:" to the end of documentation as usual
for kernel-doc.

Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
---
 lib/igt_kmod.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index d98e6c5f9..74017ddc2 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -211,14 +211,10 @@ out:
  * @opts: Parameters for the module. NULL in case no parameters
  * are to be passed, or a '\0' terminated string otherwise.
  *
- * Returns: 0 in case of success or -errno in case the module could not
- * be loaded.
- *
  * This function loads a kernel module using the name specified in @mod_name.
  *
- * @Note: This functions doesn't automatically resolve other module
- * dependencies so make make sure you load the dependencies module(s) before
- * this one.
+ * Returns: 0 in case of success or -errno in case the module could not
+ * be loaded.
  */
 int
 igt_kmod_load(const char *mod_name, const char *opts)
-- 
2.40.1



More information about the igt-dev mailing list