[igt-dev] [PATCH i-g-t 1/2] igt_runner: don't require root for dry_run

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Oct 20 11:27:58 UTC 2023


Hi Mauro,
On 2023-10-20 at 12:20:32 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> When --dry-run option is used, there's no need to require root,
> as no tests will actually be executed.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  runner/settings.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/runner/settings.c b/runner/settings.c
> index 23aa82963344..788957948b4f 100644
> --- a/runner/settings.c
> +++ b/runner/settings.c
> @@ -687,6 +687,7 @@ bool parse_options(int argc, char **argv,
>  			break;
>  		case OPT_DRY_RUN:
>  			settings->dry_run = true;
> +			settings->allow_non_root = true;
>  			break;
>  		case OPT_ALLOW_NON_ROOT:
>  			settings->allow_non_root = true;
> -- 
> 2.41.0
> 


More information about the igt-dev mailing list