[igt-dev] [PATCH 6/7] benchmarks/gem_exec_tracer.c: Fix musl build

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Oct 24 16:09:33 UTC 2023


Hi Bernd,
On 2023-10-22 at 17:52:25 +0200, Bernd Kuhls wrote:
> From: mhmdanas <triallax at tutanota.com>
------- ^^^^^^^^
Please no nicks in author or s-o-b, write here full name.

+cc Petri

Btw did you check against new igt sources, v1.28?

> 
> Original patch was added to void-linux:
> https://github.com/void-linux/void-packages/commit/111918317d06598fe1459dbe139923404f3f4b9d
> 
> Bug report with request to split the original patch into some
> functional changes:
> https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/138

Please move gitlab link below.

> 
> Fixes build error:
> ../benchmarks/gem_exec_tracer.c:274:1: error: conflicting types for ‘ioctl’; have ‘int(int,  long unsigned int, ...)’
>   274 | ioctl(int fd, unsigned long request, ...)

Write "Link: ..." here:

Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/138
> Signed-off-by: Bernd Kuhls <bernd at kuhls.net>

Regards,
Kamil

> ---
>  benchmarks/gem_exec_tracer.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/benchmarks/gem_exec_tracer.c b/benchmarks/gem_exec_tracer.c
> index 7e86473e4..3156dfc23 100644
> --- a/benchmarks/gem_exec_tracer.c
> +++ b/benchmarks/gem_exec_tracer.c
> @@ -271,7 +271,11 @@ static int is_i915(int fd)
>  }
>  
>  int
> +#ifdef __GLIBC__
>  ioctl(int fd, unsigned long request, ...)
> +#else
> +ioctl(int fd, int request, ...)
> +#endif
>  {
>  	struct trace *t, **p;
>  	va_list args;
> -- 
> 2.39.2
> 


More information about the igt-dev mailing list