[igt-dev] [PATCH i-g-t 5/5] tests/intel/kms_psr: made test compaitable with pr

Joshi, Kunal1 kunal1.joshi at intel.com
Wed Oct 25 06:49:06 UTC 2023


Hello Jouni,

Missed commenting on one of the review comments,
PSR_MODE_1 repeated should be PSR_MODE_2,
>  
> -       for (data.op_psr_mode = PSR_MODE_1; data.op_psr_mode <= 
> PSR_MODE_2;
> -            data.op_psr_mode++) {
> -
> +       for (z = 0; z < ARRAY_SIZE(modes); z++) {
> +               data.op_psr_mode = modes[z];

> Why are you changing this? To my opinion original is more clear...

This doesn't do anything for PSR_MODE_2_SEL_FETCH, so had created new array
for all the modes that need to be tested
int modes[] = {PSR_MODE_1, PSR_MODE_2, PR_MODE};

	PSR_MODE_1,
 	PSR_MODE_2,
 	PSR_MODE_2_SEL_FETCH,
+	PR_MODE,
+	PR_MODE_SEL_FETCH,
 	PSR_DISABLED,




More information about the igt-dev mailing list