[igt-dev] [PATCH i-g-t] intel/xe_exec_store.c: Fix the check for num of placements in store_all.

[Ch, Sai Gowtham]

>-----Original Message-----
>From: Kamil Konieczny <kamil.konieczny at linux.intel.com>
>Sent: Friday, October 27, 2023 8:48 PM
>To: Ch, Sai Gowtham <sai.gowtham.ch at intel.com>
>Cc: igt-dev at lists.freedesktop.org
>Subject: Re: [igt-dev] [PATCH i-g-t] intel/xe_exec_store.c: Fix the check for num
>of placements in store_all.
>
>Hi Sai,
>
>On 2023-10-27 at 18:47:46 +0530, sai.gowtham.ch at intel.com wrote:
>> From: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
>>
>
>please improve subject:
>
>[PATCH i-g-t] intel/xe_exec_store.c: Fix the check for num of placements in
>store_all.
>-------------------------------- ^^ ------------------------------------------------ ^ Drop ".c" and
>last dot ".":
>s/_store.c:/_store:/
>s/_all./_all/
>
>Also add "tests/" at begin:
>
>[PATCH i-g-t] tests/intel/xe_exec_store: Fix the check for num of placements in
>store_all
>
>> Intension is to run this test on GT's with supported engines and whose
>> number of placements expected to be atleast one.
>--------------------------------------^
>s/atleast/at least/
>
>>
>> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
>> ---
>>  tests/intel/xe_exec_store.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/intel/xe_exec_store.c b/tests/intel/xe_exec_store.c
>> index 90684b8cb..0b084eb10 100644
>> --- a/tests/intel/xe_exec_store.c
>> +++ b/tests/intel/xe_exec_store.c
>> @@ -147,7 +147,8 @@ static void store_all(int fd, int gt, int class)
>>  		eci[num_placements++] = *hwe;
>>  	}
>>
>> -	igt_require(num_placements);
>> +	if (num_placements < 1)
>> +		return;
>
>This change could hide case when no test will be executed.
>
Could you please elaborate ? what do you mean by when no test will be executed ? 

----------
Gowtham 
>Regards,
>Kamil
>
>>
>>  	for (i = 0; i < num_placements; i++) {
>>  		struct drm_xe_exec_queue_create create = {
>> --
>> 2.39.1
>>