[igt-dev] [PATCH i-g-t v2 7/7] runner/runner_tests: add a test to check case-insensitive match

[Kamil Konieczny]

Hi Mauro,
On 2023-10-30 at 10:50:02 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> As regular expressions are now case-insensitive, add ab
> unit test to verify that case-insensitive logic is working
> as expected.
> 
> CC: Petri Latvala <adrinael at adrinael.net>
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  runner/runner_tests.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/runner/runner_tests.c b/runner/runner_tests.c
> index 11ff05bc0e7e..0aa7dd6626b7 100644
> --- a/runner/runner_tests.c
> +++ b/runner/runner_tests.c
> @@ -1813,13 +1813,16 @@ igt_main
>  	igt_subtest_group {
>  		const char testlisttext[] = "igt at successtest";
>  		const char blocktext[] = "igt at successtest@first";
> +		const char blocktext_upper[] = "igt at successTEST@first";
>  		struct job_list *list = malloc(sizeof(*list));
>  		volatile int dirfd = -1;
>  		char dirname[] = "tmpdirXXXXXX";
>  		volatile int listfd;
>  		volatile int blockfd;
> +		volatile int blockfd_upper;
>  		char listfilename[] = "tmplistXXXXXX";
>  		char blockfilename[] = "tmpblockXXXXXX";
> +		char blockfilename_upper[] = "tmpBLOCKXXXXXX";
>  
>  		igt_fixture {
>  			igt_require(mkdtemp(dirname) != NULL);
> @@ -1829,8 +1832,11 @@ igt_main
>  			igt_require(write(listfd, testlisttext, strlen(testlisttext)) == strlen(testlisttext));
>  			igt_require((blockfd = mkstemp(blockfilename)) >= 0);
>  			igt_require(write(blockfd, blocktext, strlen(blocktext)) == strlen(blocktext));
> +			igt_require((blockfd_upper = mkstemp(blockfilename_upper)) >= 0);
> +			igt_require(write(blockfd_upper, blocktext_upper, strlen(blocktext_upper)) == strlen(blocktext_upper));
>  			close(listfd);
>  			close(blockfd);
> +			close(blockfd_upper);
>  
>  			init_job_list(list);
>  		}
> @@ -1870,9 +1876,28 @@ igt_main
>  			igt_assert_eqstr(list->entries[0].subtests[0], "second-subtest");
>  		}
>  
> +		igt_subtest("only-binary-name-in-testlist-with-case-insensitive-blocklist") {
> +			const char *argv[] = { "runner",
> +				"--allow-non-root",
> +				"--test-list", listfilename,
> +				"-b", blockfilename_upper,
> +				testdatadir,
> +				dirname,
> +			};
> +
> +			igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
> +
> +			igt_assert(create_job_list(list, settings));
> +			/* No multi-mode, binary has two subtests, one of them blocked */
> +			igt_assert_eq(list->size, 1);
> +			igt_assert_eq(list->entries[0].subtest_count, 1);
> +			igt_assert_eqstr(list->entries[0].subtests[0], "second-subtest");
> +		}
> +
>  		igt_fixture {
>  			unlink(listfilename);
>  			unlink(blockfilename);
> +			unlink(blockfilename_upper);
>  			close(dirfd);
>  			clear_directory(dirname);
>  			free_job_list(list);
> -- 
> 2.41.0
>