[igt-dev] [PATCH i-g-t v2 2/9] lib/intel_compute: Add compatibility flags for running compute
Zbigniew Kempczyński
zbigniew.kempczynski at intel.com
Tue Sep 5 13:33:02 UTC 2023
Allow selectively turn on/off compute tests on both i915 and xe
drivers.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Cc: Christoph Manszewski <christoph.manszewski at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Mauro Carvalho Chehab <mchehab at kernel.org>
---
lib/intel_compute.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/lib/intel_compute.c b/lib/intel_compute.c
index 647bce0e43..dd9f686d0c 100644
--- a/lib/intel_compute.c
+++ b/lib/intel_compute.c
@@ -446,17 +446,27 @@ static void tgl_compute_exec(int fd, const unsigned char *kernel,
}
/*
- * Generic code
+ * Compatibility flags.
+ *
+ * There will be some time period in which both drivers (i915 and xe)
+ * will support compute runtime tests. Lets define compat flags to allow
+ * the code to be shared between two drivers allowing disabling this in
+ * the future.
*/
+#define COMPAT_FLAG(f) (1 << (f))
+#define COMPAT_I915 COMPAT_FLAG(INTEL_DRIVER_I915)
+#define COMPAT_XE COMPAT_FLAG(INTEL_DRIVER_XE)
static const struct {
unsigned int ip_ver;
void (*compute_exec)(int fd, const unsigned char *kernel,
unsigned int size);
+ uint32_t compat;
} compute_batches[] = {
{
.ip_ver = IP_VER(12, 0),
.compute_exec = tgl_compute_exec,
+ .compat = COMPAT_I915 | COMPAT_XE,
},
};
@@ -465,6 +475,7 @@ bool run_compute_kernel(int fd)
unsigned int ip_ver = intel_graphics_ver(intel_get_drm_devid(fd));
unsigned int batch;
const struct compute_kernels *kernels = compute_square_kernels;
+ enum intel_driver driver = get_intel_driver(fd);
for (batch = 0; batch < ARRAY_SIZE(compute_batches); batch++) {
if (ip_ver == compute_batches[batch].ip_ver)
@@ -473,6 +484,12 @@ bool run_compute_kernel(int fd)
if (batch == ARRAY_SIZE(compute_batches))
return false;
+ if (!(COMPAT_FLAG(driver) & compute_batches[batch].compat)) {
+ igt_debug("driver flag: %x\n", COMPAT_FLAG(driver));
+ igt_debug("compat flag: %x\n", compute_batches[batch].compat);
+ return false;
+ }
+
while (kernels->kernel) {
if (ip_ver == kernels->ip_ver)
break;
--
2.34.1
More information about the igt-dev
mailing list