[igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Reduce the number of iterations on modeset-transition

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Sep 7 07:58:22 UTC 2023


Hi Mohammed,

On 2022-04-21 at 19:49:35 +0530, Mohammed Thasleem wrote:
> Due to the higher number of iterations, "modeset-transition" tests are
> getting timed out on CI. Reducing the number of iterations can save a
> lot of execution time.
> 
> Instead of having (2 ^ j) iterations, reduce it to (2 * j) where j is
> the number of active pipes.
> 
> v2: Update commit message.
> v3: Update commit message and minor changes.
> 
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
> ---
>  tests/kms_atomic_transition.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index a470eb88c..6c914ec21 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -966,10 +966,7 @@ retry:
>  		}
>  	}
>  
> -	iter_max = 1 << j;
> -
> -	if (igt_run_in_simulation() && iter_max > 1)
> -		iter_max = iter_max >> 1;

Why did you deleted above two in_simulation lines?
Now for j=1 and in_simulation() true, number of iterations
will be 2 instead of 1, so it will increase.

> +	iter_max = (j > 0) ? (j << 1) : 1;

Move this above before in_simulation check.

Regards,
Kamil

>  
>  	if (igt_display_try_commit_atomic(&data->display,
>  				DRM_MODE_ATOMIC_TEST_ONLY |
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list