[igt-dev] [PATCH i-g-t v4 4/4] lib/xe_spin.c: fixed checkpatch issue

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Sep 8 17:10:21 UTC 2023


Hi Marcin,

now checkpatch complains about subject of your change:
WARNING: A patch subject line should describe the change not the tool that found it
#4: 
Subject: [PATCH i-g-t 4/4] lib/xe_spin.c: fixed checkpatch issue

so I suggest other, like: fixed code style

with that:
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Regards,
Kamil

On 2023-09-08 at 12:54:54 +0000, Marcin Bernatowicz wrote:
> fixed checkpatch reported error
> 
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
> ---
>  lib/xe/xe_spin.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/xe/xe_spin.c b/lib/xe/xe_spin.c
> index d8e2c07aa..f0d77aed3 100644
> --- a/lib/xe/xe_spin.c
> +++ b/lib/xe/xe_spin.c
> @@ -165,7 +165,8 @@ bool xe_spin_started(struct xe_spin *spin)
>   */
>  void xe_spin_wait_started(struct xe_spin *spin)
>  {
> -	while(!xe_spin_started(spin));
> +	while (!xe_spin_started(spin))
> +		;
>  }
>  
>  void xe_spin_end(struct xe_spin *spin)
> -- 
> 2.30.2
> 


More information about the igt-dev mailing list