[igt-dev] [PATCH i-g-t v4 08/11] scripts/test_list.py: fix gen_testlist logic

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Sep 8 17:51:45 UTC 2023


Hi Mauro,
On 2023-09-08 at 10:27:44 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> Don't try to find a common prefix for tests, as this cause
> troubles when filtering out tests.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  scripts/test_list.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/scripts/test_list.py b/scripts/test_list.py
> index c9073cc0305f..01f6528ac84c 100644
> --- a/scripts/test_list.py
> +++ b/scripts/test_list.py
> @@ -1352,8 +1352,6 @@ class TestList:
>  
>          """Generate testlists from the test documentation"""
>  
> -        test_prefix = os.path.commonprefix(self.get_subtests()[""])
> -        test_prefix = re.sub(r'^' + self.main_name, '', test_prefix)
>  
>          # NOTE: currently, it uses a comma for multi-value delimitter
>          test_subtests = self.get_subtests(sort_field, ",", with_order = True)
> @@ -1374,7 +1372,7 @@ class TestList:
>                  fname = testlist
>  
>              fname = re.sub(r"[^\w\d]+", "-", fname)
> -            fname = directory + "/" + test_prefix + fname + ".testlist"
> +            fname = directory + "/" + fname + ".testlist"
>  
>              with open(fname, 'w', encoding='utf8') as handler:
>                  for sub in test_subtests[test]:
> -- 
> 2.41.0
> 


More information about the igt-dev mailing list