[igt-dev] [PATCH i-g-t v2] lib/i915: Add a helper to read mmio registers via ioctl

[Teres Alexis, Alan Previn]

Hi Kamil,

Apologies for the tardy response.
Thanks again for taking the time to review.
I will fix everything below as per your recommendation.
might need some trivial mods to callers.

alan:snip

I do wanna explain the below hunk specifically though, but i prefer your recommendation:
On one of my first upstream patch reviews, i was asked to re-arrange the headers of a hunk
to be alphabetical eventhough my change was just adding 1 header.
I'll fix below to add just the needed. :)

> > --- a/tools/i915-perf/i915_perf_recorder.c
> > +++ b/tools/i915-perf/i915_perf_recorder.c
> > @@ -44,14 +44,15 @@
> >  
> >  #include <i915_drm.h>
> >  
> > -#include "i915/i915_drm_local.h"
> > -
> > +#include "i915_perf_recorder_commands.h"
> 
> Why do you touch unrelated headers?
> 
> >  #include "igt_core.h"
> >  #include "intel_chipset.h"
> > +
> > +#include "i915/i915_drm_local.h"
> >  #include "i915/perf.h"
> >  #include "i915/perf_data.h"
> >  
> > -#include "i915_perf_recorder_commands.h"
> > +#include "lib/intel_reg.h"
> ------------ ^^^^^^^^^^^^^^^
> You need only this here.