[igt-dev] [PATCH i-g-t 1/2] lib/intel_batchbuffer: Add Meteorlake gpgpu fill entry

[Zbigniew Kempczyński]

On Wed, Sep 13, 2023 at 05:59:50PM +0200, Kamil Konieczny wrote:
> Hi Zbigniew,
> 
> On 2023-09-13 at 16:24:16 +0200, Zbigniew Kempczyński wrote:
> > From: Arjun Melkaveri <arjun.melkaveri at intel.com>
> > 
> > Meteorlake is using XeHP pipeline for gpgpu fill so it must be
> > added first as it is an exception in newer platforms condition.
> > 
> > Signed-off-by: Arjun Melkaveri <arjun.melkaveri at intel.com>
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Cc: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> > ---
> >  lib/intel_batchbuffer.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> > index 682c0fe1d2..e7b1b755fd 100644
> > --- a/lib/intel_batchbuffer.c
> > +++ b/lib/intel_batchbuffer.c
> > @@ -755,7 +755,9 @@ igt_fillfunc_t igt_get_gpgpu_fillfunc(int devid)
> >  {
> >  	igt_fillfunc_t fill = NULL;
> >  
> > -	if (intel_graphics_ver(devid) >= IP_VER(12, 60))
> > +	if (IS_METEORLAKE(devid))
> 
> May you add comment here? like:
> 
> 	if (IS_METEORLAKE(devid)) /* exception - MTL uses XeHP pipeline */

I think this condition doesn't deserve for own comment. I think
condition itself is clearly self documenting.

Thanks for the review.

--
Zbigniew
> 
> With or without it:
> Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> 
> > +		fill = xehp_gpgpu_fillfunc;
> > +	else if (intel_graphics_ver(devid) >= IP_VER(12, 60))
> >  		fill = xehpc_gpgpu_fillfunc;
> >  	else if (intel_graphics_ver(devid) >= IP_VER(12, 50))
> >  		fill = xehp_gpgpu_fillfunc;
> > -- 
> > 2.34.1
> >