[igt-dev] [PATCH i-g-t v3] lib/i915: Add a helper to read mmio registers via ioctl

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Fri Sep 15 01:40:26 UTC 2023


On Tue, 2023-09-12 at 11:31 +0200, Kamil Konieczny wrote:
> Hi Alan,
> 
> one more small nit, see below.
> 
> On 2023-09-11 at 10:15:09 -0700, Alan Previn wrote:
> > Add a helper into existing ioctl_wrappers.c  to call
> > DRM_IOCTL_I915_REG_READ to read whitelisted registers.
> > 
alan:snip

> > --- a/tools/i915-perf/i915_perf_recorder.c
> > +++ b/tools/i915-perf/i915_perf_recorder.c
> > @@ -48,10 +48,12 @@
> >  
> >  #include "igt_core.h"
> >  #include "intel_chipset.h"
> > +
> --^
> Remove this additional newline.
> 
alan: will do - apologies - habit from kernel (grouping doimains of include)


More information about the igt-dev mailing list