[igt-dev] [PATCH i-g-t 2/3] tests/intel/gem_ctx_shared: Skip some test on MTL
Kamil Konieczny
kamil.konieczny at linux.intel.com
Fri Sep 15 18:02:15 UTC 2023
Hi Nirmoy,
On 2023-09-14 at 22:18:08 +0200, Nirmoy Das wrote:
> We do GGTT update on MTL using bcs engine, blocking that would
---------------------------------------------------------- ^^^^^
> will fail the test so skip such subtests on bcs engine for MTL.
- ^^^^
s/will//
With that fixed:
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
>
> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
> ---
> tests/intel/gem_ctx_shared.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/tests/intel/gem_ctx_shared.c b/tests/intel/gem_ctx_shared.c
> index d24ae5483..fd429306e 100644
> --- a/tests/intel/gem_ctx_shared.c
> +++ b/tests/intel/gem_ctx_shared.c
> @@ -1047,6 +1047,12 @@ static void smoketest(int i915, const intel_ctx_cfg_t *cfg,
> for_each_if(gem_class_can_store_dword(i915, (e)->class)) \
> igt_dynamic_f("%s", e->name)
>
> +#define for_each_nonblocking_ggtt_binder_queue(e, i915, cfg) \
> + for_each_ctx_cfg_engine(i915, cfg, e) \
> + for_each_if(gem_class_can_store_dword(i915, (e)->class) && \
> + !gem_engine_can_block_ggtt_binder(i915, e)) \
> + igt_dynamic_f("%s", e->name)
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -1104,22 +1110,22 @@ igt_main
> }
>
> igt_subtest_with_dynamic("Q-independent") {
> - for_each_queue(e, i915, &cfg)
> + for_each_nonblocking_ggtt_binder_queue(e, i915, &cfg)
> independent(i915, &cfg, e, 0);
> }
>
> igt_subtest_with_dynamic("Q-in-order") {
> - for_each_queue(e, i915, &cfg)
> + for_each_nonblocking_ggtt_binder_queue(e, i915, &cfg)
> reorder(i915, &cfg, e->flags, EQUAL);
> }
>
> igt_subtest_with_dynamic("Q-out-order") {
> - for_each_queue(e, i915, &cfg)
> + for_each_nonblocking_ggtt_binder_queue(e, i915, &cfg)
> reorder(i915, &cfg, e->flags, 0);
> }
>
> igt_subtest_with_dynamic("Q-promotion") {
> - for_each_queue(e, i915, &cfg)
> + for_each_nonblocking_ggtt_binder_queue(e, i915, &cfg)
> promotion(i915, &cfg, e->flags);
> }
> }
> --
> 2.41.0
>
More information about the igt-dev
mailing list