[igt-dev] [PATCH i-g-t v4] lib/i915: Add a helper to read mmio registers via ioctl

[Teres Alexis, Alan Previn]

On Fri, 2023-09-15 at 19:55 +0200, Kamil Konieczny wrote:
> Hi Alan,
> On 2023-09-14 at 20:29:14 -0700, Alan Previn wrote:
> > +__u64 i915_reg_read_ioctl(int drmfd, __u64 offset)
> > +{
> > +	__u64 value;
> > +
> > +	igt_assert_eq(__i915_reg_read_ioctl(drmfd, offset, &value), 0);
> > +	errno = 0;
> --- ^
> Delete this, you already checked errno in assert.
> Put one empty line before return from function.
> 
> Rest looks good.
> 

alan: got it. thanks for your patience.