[igt-dev] [PATCH] core_getversion: Test for desired device

Rob Clark robdclark at gmail.com
Thu Sep 21 22:44:22 UTC 2023


From: Rob Clark <robdclark at chromium.org>

We discovered in drm/ci that if the drm device fails to probe, all the
tests come back as "Skip", and the job is considered successful.  So fix
the getversion test to fail if there is no drm device, or if the drm
device does not match the expected device.

Signed-off-by: Rob Clark <robdclark at chromium.org>
---
 tests/core_getversion.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/core_getversion.c b/tests/core_getversion.c
index 32cb976e4923..e5416993d7a3 100644
--- a/tests/core_getversion.c
+++ b/tests/core_getversion.c
@@ -48,14 +48,18 @@ igt_simple_main
 {
 	int fd;
 	drmVersionPtr v;
+	const char *name = getenv("IGT_REQUIRED_DRIVERS");
 
-	fd = drm_open_driver(DRIVER_ANY);
+	fd = __drm_open_driver(DRIVER_ANY);
+	igt_assert_fd(fd);
 	v = drmGetVersion(fd);
 	igt_assert_neq(strlen(v->name), 0);
 	igt_assert_neq(strlen(v->date), 0);
 	igt_assert_neq(strlen(v->desc), 0);
 	if (is_i915_device(fd))
 		igt_assert_lte(1, v->version_major);
+	if (name)
+		igt_assert_eq(strcmp(name, v->name), 0);
 
 	drmFree(v);
 	drm_close_driver(fd);
-- 
2.41.0



More information about the igt-dev mailing list