[igt-dev] [PATCH i-g-t] lib/xe: on xe driver use blitter for x-tile

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Fri Sep 22 10:32:21 UTC 2023


Thanks. Those ci reported failures don't seem to relate to this change 
at all so I'll change subject/message and push.

/Juha-Pekka

On 22.9.2023 7.54, Sharma, Swati2 wrote:
> Hi JP,
> 
> Since for xe, we want to use blitter generically, please update commit 
> message and subject accordingly.
> 
> With above fixed.
> 
> LGTM
> Reviewed-by: Swati Sharma <swati2.sharma at intel.com>
> 
> On 21-Sep-23 10:05 PM, Juha-Pekka Heikkila wrote:
>> on xe driver need to use blitter for x-tile
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>> ---
>>   lib/igt_fb.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>> index 4b592825d..c8a7b31a8 100644
>> --- a/lib/igt_fb.c
>> +++ b/lib/igt_fb.c
>> @@ -2557,7 +2557,8 @@ static bool use_blitter(const struct igt_fb *fb)
>>       return fb->modifier == I915_FORMAT_MOD_4_TILED ||
>>              fb->modifier == I915_FORMAT_MOD_Y_TILED ||
>>              fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
>> -           (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
>> +           (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd)) ||
>> +           is_xe_device(fb->fd);
>>   }
>>   static void init_buf_ccs(struct intel_buf *buf, int ccs_idx,



More information about the igt-dev mailing list